Adding basic version of DUMP and RESTORE commands #899
Conversation
|
@microsoft-github-policy-service agree |
s3w3nofficial
force-pushed
the
s3w3nofficial/add-dump-and-restore-command
branch
from
f9c9838 to
2954d6e
Compare
| /// <summary> | ||
| /// Utils for working with redis length encoding | ||
| /// </summary> | ||
| public static class RedisLengthEncodingUtils |
There was a problem hiding this comment.
Rename redis -> resp, e.g., RespLengthEncodingUtils to clarify that this is related to the RESP protocol.
since you only ported the pycrc generated version, it seems we should be okay as it is ... |
| /// </summary> | ||
| /// <param name="data"></param> | ||
| /// <returns></returns> | ||
| public static byte[] Hash(ReadOnlySpan<byte> data) |
There was a problem hiding this comment.
Is there a reason for the custom CRC64 implementation? Have you tried using System.IO.Hashing.Crc64.Hash(data) instead?
| @@ -90,6 +90,7 @@ public enum RespCommand : ushort | |||
| ZSCAN, | |||
| ZSCORE, // Note: Last read command should immediately precede FirstWriteCommand | |||
| ZUNION, | |||
| DUMP, | |||
There was a problem hiding this comment.
Please add a slot verification test for DUMP
E.g.:
| @@ -174,6 +175,7 @@ public enum RespCommand : ushort | |||
| ZREMRANGEBYRANK, | |||
| ZREMRANGEBYSCORE, | |||
| ZUNIONSTORE, | |||
| RESTORE, | |||
There was a problem hiding this comment.
Same as above add a slot verification test.
E.g.
Currently only work's on string type and does not support compression, but it's still a solid starting point.
Implemented
Not Implemented
Also about the copyright for the crc64, i only ported the pycrc generated version, but still i'm not sure if and which copyright should i add.