Enabled Linux UVM tests to run on 1ES github runner pool #2357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/ci.yml
Outdated
| run: | | ||
| mv ./downloaded_artifacts/LinuxBootFiles/kernel ${{ env.LINUX_BOOT_FILES_PATH }}/ | ||
| mv ./downloaded_artifacts/LinuxBootFiles/vmlinux ${{ env.LINUX_BOOT_FILES_PATH }}/ | ||
| mv ./downloaded_artifacts/rootfs-*.tar.gz . |
There was a problem hiding this comment.
Nit: I think it would be clearer to use a specific directory name for where we're putting the temporary rootfs
There was a problem hiding this comment.
Sounds good, added a directory name for the temp rootfs.
.github/workflows/ci.yml
Outdated
| echo "The full file name is $ROOTFS_TAR" | ||
|
|
||
| make clean | ||
| sudo make BASE=${{ github.workspace }}/$ROOTFS_TAR rootfs |
There was a problem hiding this comment.
Can we also set "KMOD=1" as an arg to make?
jiechen0826
force-pushed
the
jiechen3/github_runner
branch
2 times, most recently
from
ad4e412 to
521163c
Compare
jiechen0826
force-pushed
the
jiechen3/github_runner
branch
2 times, most recently
from
41c33bb to
52a0e9b
Compare
Skipped uvm plan9 test until azurelinux rootfs is fixed Signed-off-by: Jie Chen <[email protected]>
jiechen0826
force-pushed
the
jiechen3/github_runner
branch
from
ecf1c0b to
897ca55
Compare
|
Once #2359 is merged, TestLCOW_IPv6_Assignment will pass in CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the CI workflow configuration in
.github/workflows/ci.yml.The purpose of the change is to enable the Linux UVM tests in the CI workflow. Similar to the Windows UVM tests, the Linux UVM tests will be run on the 1ES Github Runner pool which supports nested virtualization.
The changes introduce a new job to create Linux boot files, modify existing jobs to incorporate these files, and update environment variables.
CI Workflow Enhancements:
New Job for Linux Boot Files Creation:
create-linux-boot-filesjob to handle the creation and preparation of Linux boot files. This job includes steps for authenticating with Azure, downloading LCOW artifacts from the dev feed, and creating new rootfs for subsequent testing of the Linux GCS.Environment Variables:
LCOW_ARTIFACT_PROJECT,LCOW_ARTIFACT_FEED,LCOW_ARTIFACT_NAME,LCOW_ARTIFACT_VERSION,LINUX_BOOT_FILES_PATH) to support the new job and its steps.Job Dependencies:
test-windowsjob to depend on the newcreate-linux-boot-filesjob to ensure the necessary Linux boot files are available for testing.Linux Boot Files Integration:
test-windowsjob to create a directory for Linux boot files, download the boot files from the artifact, and extract them for use in tests.Test Command Update:
test-windowsjob to include the path to the Linux boot files, ensuring that the tests utilize the newly created files.