Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add a subfolder to the default vscode output path #6054

Merged
merged 3 commits into from
Jan 24, 2025
Merged

fix: add a subfolder to the default vscode output path #6054

merged 3 commits into from
Jan 24, 2025
+55 −25

Conversation

calebkiage
Copy link
Contributor

@calebkiage calebkiage commented Jan 23, 2025 •
edited
Loading

closes #5977

@calebkiage calebkiage requested a review from a team as a code owner January 23, 2025 12:32
baywet
baywet previously approved these changes Jan 23, 2025
View reviewed changes
@calebkiage calebkiage marked this pull request as draft January 23, 2025 14:29
@calebkiage
Copy link
Contributor Author

Still need to handle the situation where the directory exists already.

@calebkiage calebkiage marked this pull request as ready for review January 23, 2025 16:37
@calebkiage calebkiage merged commit 85d3e62 into main Jan 24, 2025
243 checks passed
@calebkiage calebkiage deleted the fix/issue-5977 branch January 24, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewahome thewahome thewahome approved these changes

@baywet baywet baywet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Status: Done ✔️
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kiota deletes all files in the directory when output clear is enabled, not only generated files
3 participants
@calebkiage @baywet @thewahome