Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for multiple connections #76

Merged
merged 2 commits into from
Jun 16, 2023
Merged

Support for multiple connections #76

merged 2 commits into from
Jun 16, 2023

Conversation

jcamachor
Copy link
Contributor

@jcamachor jcamachor commented Jun 15, 2023 •
edited
Loading

See #16.

@jcamachor
Copy link
Contributor Author

@ashvina , @anjagruenheid , could any of you review? Thanks

ashvina
ashvina reviewed Jun 15, 2023
View reviewed changes
Copy link
Contributor

@ashvina ashvina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
I have added a few clarification questions and suggestions in the comments.

src/main/java/com/microsoft/lst_bench/exec/SessionExec.java Outdated Show resolved Hide resolved
src/main/resources/config/tpcds/wp3_rw_concurrency_multi.yaml Outdated Show resolved Hide resolved
src/main/java/com/microsoft/lst_bench/input/Session.java Outdated Show resolved Hide resolved
src/main/resources/schemas/workload.json Outdated Show resolved Hide resolved
@jcamachor jcamachor mentioned this pull request Jun 16, 2023
Open
@jcamachor jcamachor merged commit 3df258f into microsoft:main Jun 16, 2023
@jcamachor jcamachor deleted the multi-connection branch June 16, 2023 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashvina ashvina ashvina left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcamachor @ashvina