ReleaseWorkflow.yml: Create PR to update version #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the release workflow to trigger on a published release event and create a PR that updates the version of the crate(s) in the workspace instead of pushing a commit directly to the default branch.
|
Were you able to test run this? |
@apop5 Yes, this is actively being used on a private repo and is working :) |
makubacki
reviewed
Jan 24, 2025
There was a problem hiding this comment.
Can you update the file description to reflect that the workflow no longer creates a release on GitHub but runs when a release is published?
Have/can you double check it with a test on a repo in the microsoft org? I'm assuming you enabled similar permissions, but this would double check nothing was missed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the release workflow to trigger on a published release event and create a PR that updates the version of the crate(s) in the workspace instead of pushing a commit directly to the default branch.