-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement some missing element wise Add/Sub/Mul/Div/Neg operations for CPU and CUDA EPs #23090
base: main
Are you sure you want to change the base?
Conversation
This will increase binary size. Is the missing type used in any real model? |
@microsoft-github-policy-service agree company="Cellumation" |
I do not know if any "real" model use these types for these operations. |
This may increase the binary size. +@scottmckay |
@Zyrin, please following Also need update documents (You can find the updated documents in artifacts of Windows GPU Doc Gen CI Pipeline from Checks). |
/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline |
/azp run Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-linux-gpu-ci-pipeline,onnxruntime-binary-size-checks-ci-pipeline,Big Models,Linux Android Emulator QNN CI Pipeline,Android CI Pipeline |
/azp run iOS CI Pipeline,ONNX Runtime React Native CI Pipeline,CoreML CI Pipeline,Linux DNNL CI Pipeline,Linux MIGraphX CI Pipeline,Linux ROCm CI Pipeline |
Azure Pipelines successfully started running 6 pipeline(s). |
Azure Pipelines successfully started running 9 pipeline(s). |
Azure Pipelines successfully started running 10 pipeline(s). |
7fcfd3b
to
92d0502
Compare
I applied the linting fixes. @tianleiwu could you restart the pipelines? |
/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline |
/azp run Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,onnxruntime-binary-size-checks-ci-pipeline,Big Models,Linux Android Emulator QNN CI Pipeline |
/azp run Android CI Pipeline,iOS CI Pipeline,ONNX Runtime React Native CI Pipeline,CoreML CI Pipeline,Linux DNNL CI Pipeline,Linux MIGraphX CI Pipeline,Linux ROCm CI Pipeline |
Azure Pipelines successfully started running 7 pipeline(s). |
Azure Pipelines successfully started running 8 pipeline(s). |
Azure Pipelines successfully started running 10 pipeline(s). |
@Zyrin, there are some build pipeline failed. You need update the unit tests to run on cuda and cpu provider only. See some examples in the same test file. You will also need update operator documents (you can get them from artifacts of Windows GPU Doc Gen CI Pipeline). |
@tianleiwu I assume you want me to only run the tests on the CPU and CUDA EPs like with the following code snipped from element_wise_ops_test.cc:1837:
Alternatively I could exclude the TensorRT and DNNL EPs, but I do not know if there are EPs that are not tested here, and thus would fail on someone else. On that account should I only change the failing tests or all the tests I added? |
Right. You can follow the code snippet to fix failing tests that is introduced by this. |
…(u)int8, (u)int16, uint32 and uint64 as well as Neg unary operation for int16 on CPU EP and implement Add/Sub/Mul/Div element wise operations for (u)int8 and (u)int16 on CUDA EP
I fixed the tests. Is there a way for me to generate the docs, or is the easiest way to generate them to trigger the Windows GPU Doc Gen CI Pipeline? |
Description
Motivation and Context
This solves #23051