Remove a hack in adjust_global_compile_flags.cmake #23313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue should have been resolved.
edgchen1
reviewed
Jan 10, 2025
| @@ -12,15 +12,6 @@ if (ANDROID) | |||
| set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,-z,max-page-size=16384") | |||
| endif() | |||
|
|
|||
| # Suggested by https://gitlab.kitware.com/cmake/cmake/-/issues/20132 | |||
There was a problem hiding this comment.
could you elaborate on why this is no longer needed?
the linked CMake issue is still open.
There was a problem hiding this comment.
Should have been resolved in this commit: https://gitlab.kitware.com/cmake/cmake/-/commit/2785364b7ba32de1f718e9e5fd049a039414a669 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove a hack in adjust_global_compile_flags.cmake because the issue should have been resolved.
Motivation and Context