Sankey update (#146)

* Update outdated packages

* Fix eslint errors

* Remove tslint comments

* Remove lodash

* Fix naming and comments

* Replace any with specific type

* Add eslint parser to dependencies

* Fix package-lock file

* Update outdated packages

* move all dependencies unrelated to code execution to devDependencies

* Bump visual version

* Add dragEvent

* Add event to function argument

* Update packages

---------

Co-authored-by: Iuliia Kulagina <[email protected]>

CHANGELOG.md

@@ -1,3 +1,6 @@
+## 3.1.1
+* Update outdated packages
+
 ## 3.1.0
 * Migration to Formatting model
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "powerbi-visuals-sankey",
-  "version": "3.1.0",
+  "version": "3.1.1",
   "description": "Sankey is a type of flow diagram in which the width of the series is in proportion to the quantity of the flow.  Use it to find major contributions to an overall flow.",
   "repository": {
     "type": "git",
@@ -26,59 +26,56 @@
   },
   "homepage": "https://github.com/Microsoft/powerbi-visuals-sankey#readme",
   "devDependencies": {
-    "@types/jasmine": "^4.3.0",
+    "@types/d3-array": "^3.0.3",
+    "@types/d3-color": "^3.1.0",
+    "@types/d3-drag": "^3.0.1",
+    "@types/d3-interpolate": "^3.0.1",
+    "@types/d3-scale": "^4.0.2",
+    "@types/d3-selection": "^3.0.3",
+    "@types/jasmine": "^4.3.5",
     "@types/karma": "^6.3.3",
-    "@typescript-eslint/parser": "^5.59.7",
+    "@typescript-eslint/eslint-plugin": "^5.61.0",
+    "@typescript-eslint/parser": "^5.61.0",
     "coveralls": "^3.1.1",
-    "jasmine": "^4.5.0",
-    "jasmine-core": "^4.5.0",
+    "eslint": "^8.44.0",
+    "eslint-plugin-powerbi-visuals": "^0.8.1",
+    "jasmine": "^5.0.2",
+    "jasmine-core": "^5.0.1",
     "karma": "^6.4.1",
     "karma-chrome-launcher": "^3.1.1",
-    "karma-coverage": "^2.2.0",
+    "karma-coverage": "^2.2.1",
     "karma-jasmine": "^5.1.0",
     "karma-junit-reporter": "^2.0.1",
-    "karma-sourcemap-loader": "^0.3.8",
+    "karma-sourcemap-loader": "^0.4.0",
     "karma-typescript": "^5.5.3",
     "karma-typescript-preprocessor": "^0.4.0",
     "karma-webpack": "^5.0.0",
-    "powerbi-models": "^1.12.1",
-    "powerbi-visuals-api": "^5.1.0",
+    "less": "^4.1.3",
+    "less-loader": "^11.1.0",
+    "playwright": "^1.27.1",
     "powerbi-visuals-tools": "^4.0.8",
-    "powerbi-visuals-utils-colorutils": "^2.3.1",
-    "powerbi-visuals-utils-dataviewutils": "^2.4.1",
-    "powerbi-visuals-utils-formattingutils": "^4.7.1",
-    "powerbi-visuals-utils-interactivityutils": "^5.7.1",
-    "powerbi-visuals-utils-svgutils": "^2.3.2",
-    "powerbi-visuals-utils-testutils": "^3.2.0",
-    "powerbi-visuals-utils-tooltiputils": "^2.5.2",
-    "powerbi-visuals-utils-typeutils": "^3.0.1",
+    "powerbi-visuals-utils-testutils": "^6.0.1",
     "style-loader": "^3.3.1",
-    "ts-loader": "^9.4.1",
+    "ts-loader": "^9.4.4",
     "ts-node": "^10.9.1",
-    "webpack": "^5.74.0"
+    "webpack": "^5.88.1"
   },
   "dependencies": {
-    "@types/d3-array": "^3.0.3",
-    "@types/d3-color": "^3.1.0",
-    "@types/d3-drag": "^3.0.1",
-    "@types/d3-interpolate": "^3.0.1",
-    "@types/d3-scale": "^4.0.2",
-    "@types/d3-selection": "^3.0.3",
-    "@typescript-eslint/eslint-plugin": "^5.42.1",
-    "d3-array": "^3.2.0",
+    "d3-array": "^3.2.4",
     "d3-color": "^3.1.0",
     "d3-drag": "^3.0.0",
     "d3-interpolate": "^3.0.1",
     "d3-scale": "^4.0.2",
     "d3-selection": "^3.0.0",
-    "eslint": "^8.27.0",
-    "eslint-plugin-powerbi-visuals": "^0.8.1",
-    "less": "^4.1.3",
-    "less-loader": "^11.1.0",
     "lodash.clonedeep": "^4.5.0",
-    "lodash.maxby": "^4.6.0",
-    "lodash.minby": "^4.6.0",
-    "lodash.uniq": "^4.5.0",
-    "playwright": "^1.27.1"
+    "powerbi-models": "^1.12.1",
+    "powerbi-visuals-api": "^5.1.0",
+    "powerbi-visuals-utils-colorutils": "^6.0.1",
+    "powerbi-visuals-utils-dataviewutils": "^6.0.1",
+    "powerbi-visuals-utils-formattingutils": "^6.0.1",
+    "powerbi-visuals-utils-interactivityutils": "^6.0.2",
+    "powerbi-visuals-utils-svgutils": "^6.0.1",
+    "powerbi-visuals-utils-tooltiputils": "^6.0.1",
+    "powerbi-visuals-utils-typeutils": "^6.0.1"
   }
 }

pbiviz.json

@@ -1,10 +1,10 @@
 {
   "visual": {
     "name": "SankeyDiagram",
-    "displayName": "Sankey 3.1.0",
+    "displayName": "Sankey 3.1.1",
     "guid": "sankey02300D1BE6F5427989F3DE31CCA9E0F32020",
     "visualClassName": "SankeyDiagram",
-    "version": "3.0.8",
+    "version": "3.1.1",
     "description": "Sankey is a type of flow diagram in which the width of the series is in proportion to the quantity of the flow.  Use it to find major contributions to an overall flow.",
     "supportUrl": "https://community.powerbi.com",
     "gitHubUrl": "https://github.com/Microsoft/powerbi-visuals-sankey"

src/behavior.ts

@@ -58,7 +58,6 @@ export class SankeyDiagramBehavior implements IInteractiveBehavior {
 
     private selectedDataPoints: SelectableDataPoint[];
 
-    // tslint:disable-next-line: function-name
     public static create(): IInteractiveBehavior {
         return new SankeyDiagramBehavior();
     }
@@ -102,7 +101,7 @@ export class SankeyDiagramBehavior implements IInteractiveBehavior {
         this.behaviorOptions.nodes.on("contextmenu", (event: PointerEvent, datum: SankeyDiagramNode) => {
             if (event) {
                 this.selectionHandler.handleContextMenu(
-                    <any>datum,
+                    datum,
                     {
                         x: event.clientX,
                         y: event.clientY

src/dataInterfaces.ts

@@ -88,7 +88,7 @@ export interface SankeyDiagramLink extends
     label: string;
     source: SankeyDiagramNode;
     destination: SankeyDiagramNode;
-    weigth: number;
+    weight: number;
     height?: number;
     dySource?: number;
     dyDestination?: number;
@@ -133,7 +133,7 @@ export interface SankeyDiagramRoleNames {
 export interface SankeyDiagramDataPoint {
     source: any;
     destination: any;
-    weigth: number;
+    weight: number;
 }
 
 export interface SankeyDiagramNodePositionSetting {