Another round of simplifying member accesses — and in particular, met… #6290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hod accesses for magic methods. The previous code had redundant (and partially incomplete) methods for evaluating calls to magic methods. This change consolidates the code and eliminates various holes.
|
Diff from mypy_primer, showing the effect of this PR on open source code: steam.py (https://github.com/Gobot1234/steam.py)
+ /tmp/mypy_primer/projects/steam.py/steam/clan.py:133:18 - error: Object of type "None" cannot be used as iterable value (reportOptionalIterable)
- 7935 errors, 23 warnings, 0 informations
+ 7936 errors, 23 warnings, 0 informations
pandas-stubs (https://github.com/pandas-dev/pandas-stubs)
+ /tmp/mypy_primer/projects/pandas-stubs/tests/test_frame.py:59:23 - error: Object of type "None" cannot be used as iterable value (reportOptionalIterable)
- 1366 errors, 0 warnings, 0 informations
+ 1367 errors, 0 warnings, 0 informations
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hod accesses for magic methods. The previous code had redundant (and partially incomplete) methods for evaluating calls to magic methods. This change consolidates the code and eliminates various holes.