Adaptive profile floating-point computations extension #2078
+4,913
−985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idavis
force-pushed
the
iadavis/adaptive-float
branch
from
71011e3 to
bcfe36d
Compare
idavis
requested review from
billti,
sezna,
swernli and
minestarks
as code owners
billti
reviewed
Jan 3, 2025
billti
reviewed
Jan 3, 2025
billti
reviewed
Jan 3, 2025
billti
reviewed
Jan 3, 2025
billti
reviewed
Jan 3, 2025
billti
reviewed
Jan 3, 2025
billti
reviewed
Jan 3, 2025
billti
reviewed
Jan 3, 2025
billti
reviewed
Jan 3, 2025
billti
reviewed
Jan 3, 2025
minestarks
reviewed
Jan 6, 2025
minestarks
reviewed
Jan 6, 2025
minestarks
reviewed
Jan 7, 2025
minestarks
approved these changes
Jan 7, 2025
billti
reviewed
Jan 7, 2025
swernli
reviewed
Jan 7, 2025
swernli
reviewed
Jan 7, 2025
swernli
reviewed
Jan 7, 2025
swernli
approved these changes
Jan 7, 2025
idavis
force-pushed
the
iadavis/adaptive-float
branch
from
d3fd711 to
ac0c880
Compare
idavis
force-pushed
the
iadavis/adaptive-float
branch
3 times, most recently
from
b5d0519 to
c3164e3
Compare
idavis
force-pushed
the
iadavis/adaptive-float
branch
from
c3164e3 to
3b1bab9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds dynamic float support implementing the floating-point computations for the AdaptiveRIF profile. This also implements
fcmpmissing from the spec which was filed as a spec bug.The
fcmpinstructions chosen were the ordered set. The spec says operations like dividing by0are undefined behavior and diving by0usually gives aNANvalue. For anyfcmpcalls we need to choose ordered or unordered. I'm not sure that it matters which we decide.This PR does not change the default profiles for the defined hardware targets.