feat(typescript-service): Pick up the writeFile override from the LanguageServiceHost when it is overridden #3491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Typescript allows plugging the writeFile implementation in the LanguageServiceHost when using a language service. It will use this override internally but in our Project code we were ignoring that setting and falling back to the default implementation. This will use the override value to write files out in
EmitFileif it is set, otherwise using the system version.Test plan
This has been tested with a custom writer in a separate change, but for this change just rely on unit testing. There will be no behavioral change unless the writeFile value is set, and by default it is not.