Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): change to src, changes was reserved keyword by action #162

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

DariuszPorowski
Copy link
Member

@DariuszPorowski DariuszPorowski commented Dec 18, 2024

📥 Pull Request

❓ What are you trying to address

This pull request updates the .github/workflows/test.yml file to change the output variable used for conditional checks from changes to src.

changes keyword is used by action itself and current filter was not working properly - it always run.

bonus: optimized taskfile and test execution

✨ Description of new changes

Changes to conditional checks in .github/workflows/test.yml

Copy link

github-actions bot commented Dec 18, 2024

Code Coverage

Package Line Rate Complexity Health
github.com/microsoft/terraform-provider-fabric/internal/auth 74% 0
github.com/microsoft/terraform-provider-fabric/internal/framework/customtypes 75% 0
github.com/microsoft/terraform-provider-fabric/internal/framework/planmodifiers 62% 0
github.com/microsoft/terraform-provider-fabric/internal/framework/typeutils 63% 0
github.com/microsoft/terraform-provider-fabric/internal/functions 72% 0
github.com/microsoft/terraform-provider-fabric/internal/pkg/fabricitem 80% 0
github.com/microsoft/terraform-provider-fabric/internal/pkg/transforms 62% 0
github.com/microsoft/terraform-provider-fabric/internal/pkg/utils 84% 0
github.com/microsoft/terraform-provider-fabric/internal/provider 86% 0
github.com/microsoft/terraform-provider-fabric/internal/provider/config 100% 0
github.com/microsoft/terraform-provider-fabric/internal/provider/utils 70% 0
github.com/microsoft/terraform-provider-fabric/internal/services/capacity 87% 0
github.com/microsoft/terraform-provider-fabric/internal/services/dashboard 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/datamart 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/datapipeline 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/domain 41% 0
github.com/microsoft/terraform-provider-fabric/internal/services/environment 84% 0
github.com/microsoft/terraform-provider-fabric/internal/services/eventhouse 84% 0
github.com/microsoft/terraform-provider-fabric/internal/services/eventstream 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/kqldatabase 78% 0
github.com/microsoft/terraform-provider-fabric/internal/services/kqlqueryset 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/lakehouse 81% 0
github.com/microsoft/terraform-provider-fabric/internal/services/mirroredwarehouse 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/mlexperiment 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/mlmodel 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/notebook 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/paginatedreport 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/report 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/semanticmodel 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/spark 74% 0
github.com/microsoft/terraform-provider-fabric/internal/services/sparkjobdefinition 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/sqlendpoint 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/warehouse 82% 0
github.com/microsoft/terraform-provider-fabric/internal/services/workspace 78% 0
Summary 74% (3667 / 4950) 0

Minimum allowed line rate is 40%

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.16%. Comparing base (3a4f914) to head (57089e0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
- Coverage   78.21%   78.16%   -0.05%     
==========================================
  Files         130      130              
  Lines       12212    12212              
==========================================
- Hits         9552     9546       -6     
- Misses       2655     2661       +6     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@PabloZaiden PabloZaiden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@DariuszPorowski DariuszPorowski merged commit 9ca471d into main Dec 18, 2024
25 checks passed
@DariuszPorowski DariuszPorowski deleted the fix/ci-filters branch December 18, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skip changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants