Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve devenv setup and ci for test #163

Merged
merged 6 commits into from
Dec 20, 2024
Merged

feat: improve devenv setup and ci for test #163

merged 6 commits into from
Dec 20, 2024

Conversation

DariuszPorowski
Copy link
Member

@DariuszPorowski DariuszPorowski commented Dec 18, 2024

πŸ“₯ Pull Request

❓ What are you trying to address

This pull request includes updates to the .devcontainer/devcontainer.json and significant modifications to the .github/workflows/test.yml file to streamline the CI/CD process and ensure proper environment setup.

✨ Description of new changes

Updates to .devcontainer/devcontainer.json:

  • Updated the Terraform version from 1.10.2 to 1.10.3 to ensure the latest features and fixes are included.
  • Added a command to change ownership of the PowerShell directory to the vscode user after the container is created.
  • Changed the path for pwsh and set powershell.powerShellDefaultVersion to pwsh.
  • Added the ms-azuretools.vscode-azure-github-copilot extension to the list of recommended extensions.

Modifications to .github/workflows/test.yml:

  • Reorganized jobs to ensure that the changes job runs first and subsequent jobs depend on its output, improving efficiency by only running tests if there are relevant changes. [1] [2]
  • Removed redundant if conditions that checked for changes, simplifying the workflow and reducing unnecessary checks. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15]
  • Ensured that the coverage-summary job runs only if there are relevant changes, improving the efficiency of the CI/CD pipeline.
  • Updated the checkout and setup-go actions to use specific commit hashes for better reliability and reproducibility. [1] [2]

Copy link

github-actions bot commented Dec 18, 2024

Code Coverage

Package Line Rate Complexity Health
github.com/microsoft/terraform-provider-fabric/internal/auth 74% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/framework/customtypes 75% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/framework/planmodifiers 62% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/framework/typeutils 63% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/functions 72% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/pkg/fabricitem 80% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/pkg/transforms 62% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/pkg/utils 84% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/provider 86% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/provider/config 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/provider/utils 70% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/capacity 87% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/dashboard 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/datamart 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/datapipeline 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/domain 41% 0 βž–
github.com/microsoft/terraform-provider-fabric/internal/services/environment 84% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/eventhouse 84% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/eventstream 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/kqldatabase 78% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/kqlqueryset 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/lakehouse 82% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/mirroredwarehouse 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/mlexperiment 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/mlmodel 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/notebook 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/paginatedreport 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/report 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/semanticmodel 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/spark 74% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/sparkjobdefinition 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/sqlendpoint 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/warehouse 82% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/workspace 78% 0 βœ”
Summary 74% (3669 / 4950) 0 βœ”

Minimum allowed line rate is 40%

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 78.21%. Comparing base (6b2bffe) to head (c7b54e6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
+ Coverage   78.19%   78.21%   +0.02%     
==========================================
  Files         130      130              
  Lines       12212    12212              
==========================================
+ Hits         9549     9552       +3     
+ Misses       2658     2655       -3     
  Partials        5        5              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Contributor

@PabloZaiden PabloZaiden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

@DariuszPorowski DariuszPorowski merged commit 258ee38 into main Dec 20, 2024
25 checks passed
@DariuszPorowski DariuszPorowski deleted the fix/devex branch December 20, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skip changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants