scroll list view on keyboard focus #232644
Open
+34
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
changed the title
|
Looks great, but it looks like it's scrolling even when tabbing to something inside the viewport? I don't think it should do that, and it would still scroll when clicking buttons and things, I think |
meganrogge
force-pushed
the
merogge/scroll-top
branch
from
2c74354 to
a79c4e9
Compare
|
Crux of the issue: |
meganrogge
force-pushed
the
merogge/scroll-top
branch
from
36cc379 to
c775480
Compare
meganrogge
commented
Nov 1, 2024
meganrogge
changed the title
meganrogge
commented
Jan 8, 2025
roblourens
reviewed
Jan 9, 2025
roblourens
reviewed
Jan 10, 2025
| @@ -480,6 +479,8 @@ export class ListView<T> implements IListView<T> { | |||
| } | |||
|
|
|||
| private _scrollToActiveElement(element: HTMLElement, container: HTMLElement) { | |||
| // The scroll event on the list only fires when scrolling down. | |||
| // If the active element is above the viewport, we need to scroll up. microsoft/vscode-copilot#9357 | |||
There was a problem hiding this comment.
IMO we shouldn't refer to issues in private repos in the OSS repo
joyceerhl
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/microsoft/vscode-copilot/issues/9357
demo.mov