Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate onebranch-style builds for arm64, too #756

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mtfriesen
Copy link
Contributor

Description

Describe the purpose of and changes within this Pull Request.

We aren't validating arm64 for onebranch-style builds, but we might as well start doing that.

Testing

Do any existing tests cover this change? Are new tests needed?

No.

Documentation

Is there any documentation impact for this change?

No.

Installation

Is there any installer impact for this change?

No.

@mtfriesen mtfriesen added build Related to building/compiling the code tests automated test gaps and improvements github_actions Pull requests that update GitHub Actions code labels Dec 2, 2024
@mtfriesen mtfriesen requested a review from a team as a code owner December 2, 2024 21:54
@mtfriesen mtfriesen enabled auto-merge (squash) December 2, 2024 21:54
@mtfriesen
Copy link
Contributor Author

I forgot this won't work nicely until ebpf-for-windows releases 0.20.0, which is imminent.

@mtfriesen mtfriesen marked this pull request as draft December 2, 2024 22:02
auto-merge was automatically disabled December 2, 2024 22:02

Pull request was converted to draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to building/compiling the code github_actions Pull requests that update GitHub Actions code tests automated test gaps and improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant