refactor: refactor play buttons

midarrlabs · Mar 1, 2022 · 45f30dc · 45f30dc
1 parent b749707
commit 45f30dc
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 17 deletions.
diff --git a/lib/media_server_web/live/movies_live/show.ex b/lib/media_server_web/live/movies_live/show.ex
@@ -13,9 +13,4 @@ defmodule MediaServerWeb.MoviesLive.Show do
       |> assign(:movie, movie)
     }
   end
-
-  @impl true
-  def handle_event("play", %{"movie" => id}, socket) do
-    {:noreply, push_redirect(socket, to: Routes.watch_movie_show_path(socket, :show, id))}
-  end
 end
diff --git a/lib/media_server_web/live/movies_live/show.html.heex b/lib/media_server_web/live/movies_live/show.html.heex
@@ -19,9 +19,8 @@
             <p><%= @movie["year"] %>  - <%= @movie["runtime"] %> minutes</p>
           </div>
           <div class="mt-4 flex md:mt-0 md:ml-4">
-            <button phx-click="play" phx-value-movie={@movie["id"]} type="button" class="ml-3 inline-flex items-center px-4 py-2 border border-transparent rounded-md shadow-sm text-sm font-medium text-white bg-slate-600 hover:bg-slate-700 focus:outline-none focus:ring-2 focus:ring-offset-2 focus:ring-slate-500">
-              Play
-            </button>
+
+            <%= live_redirect "Play", id: "play-#{ @movie["id"] }", to: Routes.watch_movie_show_path(@socket, :show, @movie["id"]), class: "ml-3 inline-flex items-center px-4 py-2 border border-transparent rounded-md shadow-sm text-sm font-medium text-white bg-slate-600 hover:bg-slate-700 focus:outline-none focus:ring-2 focus:ring-offset-2 focus:ring-slate-500" %>
           </div>
         </div>
       </div>

diff --git a/lib/media_server_web/live/series_live/show.ex b/lib/media_server_web/live/series_live/show.ex
@@ -16,9 +16,4 @@ defmodule MediaServerWeb.SeriesLive.Show do
       |> assign(:episodes, Episodes.get_all(id))
     }
   end
-
-  @impl true
-  def handle_event("play", %{"episode" => id}, socket) do
-    {:noreply, push_redirect(socket, to: Routes.watch_episode_show_path(socket, :show, id))}
-  end
 end
diff --git a/lib/media_server_web/live/series_live/show.html.heex b/lib/media_server_web/live/series_live/show.html.heex
@@ -56,9 +56,8 @@
                     <p class="mt-2">
                         <%= item["overview"] %>
                     </p>
-                    <button id={"play-#{ item["id"] }"} phx-click="play" phx-value-episode={item["id"]} type="button" class="mt-4 inline-flex items-center px-4 py-2 border border-transparent rounded-md shadow-sm text-sm font-medium text-white bg-slate-600 hover:bg-slate-700 focus:outline-none focus:ring-2 focus:ring-offset-2 focus:ring-slate-500">
-                        Play
-                    </button>
+
+                    <%= live_redirect "Play", id: "play-#{ item["id"] }", to: Routes.watch_episode_show_path(@socket, :show, item["id"]), class: "mt-4 inline-flex items-center px-4 py-2 border border-transparent rounded-md shadow-sm text-sm font-medium text-white bg-slate-600 hover:bg-slate-700 focus:outline-none focus:ring-2 focus:ring-offset-2 focus:ring-slate-500" %>
                   </div>
                 </div>
               </li>

diff --git a/test/media_server_web/live/movies_live_test.exs b/test/media_server_web/live/movies_live_test.exs
@@ -44,6 +44,6 @@ defmodule MediaServerWeb.MoviesLiveTest do
 
     {:ok, show_live, _html} = live(conn, Routes.movies_show_path(conn, :show, movie["id"]))
 
-    assert show_live |> element("button", "Play") |> render_click()
+    assert show_live |> element("#play-#{ movie["id"] }", "Play") |> render_click()
   end
 end