Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSI-PROF 2024-25 submission #41

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

jturtle
Copy link
Contributor

@jturtle jturtle commented Nov 22, 2024

We are submitting only hospitalizations. Trajectories are paired across horizon, age, and scenario. There is no stochasticity, so stochastic_run matches run_grouping. Let us know if anything looks off.

We are submitting only hospitalizations. Trajectories are paired across horizon, age, and scenario. There is no stochasticity, so stochastic_run matches run_grouping. Let us know if anything looks off.
Copy link

Run validation on files: 2024-07-28-PSI-PROF.gz.parquet

Required values:

No missing required value found

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

🟡 Warning 5043: All values associated with output type 'sample' should have a maximum of 1 decimal place

Target Columns:

🟡 Warning 602: No value found associated with the targets: inc hosp (optional), cum hosp (optional), inc inf (optional), cum inf (optional); output_type: quantile.
🟡 Warning 602: No value found associated with the targets: peak size hosp (optional); output_type: quantile.
🟡 Warning 602: No value found associated with the targets: peak time hosp (optional); output_type: cdf.

Locations:

No errors or warnings found on Location

Sample:

Column Pairing information:

Run grouping pairing:
c("scenario_id", "horizon", "age_group")
Stochastic run pairing:
c("scenario_id", "horizon", "age_group")
Number of Samples: 200

Quantiles:

No errors or warnings found on quantiles values and format

Age Group:

No errors or warnings found on Age_group

@jturtle
Copy link
Contributor Author

jturtle commented Nov 22, 2024

Oops, value rounding continues to fail to propagate from round-to-round in my submission codes. I have changed the code and am re-processing the submission with rounded trajectory values. I can re-submit, but I don't think that helps your storage issue.

@LucieContamin LucieContamin self-requested a review November 25, 2024 15:13
Copy link
Contributor

@LucieContamin LucieContamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good morning,

Thank you for the submission, I can ignore the rounding issue for now.

Thanks for the information, I just have a small remark: if you have no stochasticity, the column stochastic_run should be set to 1.
Please see the documentation:

If each model run is not stochastic, the column will be set to a unique identifier: 1 for all rows.

Please let me know if any issues or questions,
Thanks,

Lucie

- Set all stochastic_run values to 1
- Fix rounding issue for some entries of the 'value' column
Copy link

github-actions bot commented Dec 3, 2024

Run validation on files: 2024-07-28-PSI-PROF.gz.parquet

Required values:

No missing required value found

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

No errors or warnings found on Value and Type columns

Target Columns:

🟡 Warning 602: No value found associated with the targets: inc hosp (optional), cum hosp (optional), inc inf (optional), cum inf (optional); output_type: quantile.
🟡 Warning 602: No value found associated with the targets: peak size hosp (optional); output_type: quantile.
🟡 Warning 602: No value found associated with the targets: peak time hosp (optional); output_type: cdf.

Locations:

No errors or warnings found on Location

Sample:

Column Pairing information:

Run grouping pairing:
c("scenario_id", "horizon", "age_group")
Stochastic run pairing:
No stochasticity
Number of Samples: 200

Quantiles:

No errors or warnings found on quantiles values and format

Age Group:

No errors or warnings found on Age_group

Copy link
Contributor

@LucieContamin LucieContamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update

@LucieContamin LucieContamin merged commit dd420e8 into midas-network:main Dec 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants