remove GDA 4 condition for include in midgard_connection.c #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This condition appears to be a relic from when GDA 3 was supported. The block containing the gda_sql_parser_new function in this file used to have this GDA 4 condition as well, but it doesn't anymore [1], meaning that it implicitly declares the function and converts it to a pointer when GDA 5 is used, as can be seen here [2]. [1] 581404e#diff-da9c63301e7dc484369c3a9d6100fd0a [2] https://launchpadlibrarian.net/229882653/buildlog_ubuntu-xenial-s390x.midgard2-core_10.05.7.1-2_BUILDING.txt.gz
|
Can you provide a patch which cleans entire GDA4 conditions? |
|
I think the GDA 4 condition is still necessary in src/midgard_user.c: #ifdef HAVE_LIBGDA_4
gda_execute_non_select_command (connection, del_query->str, &error);
#else
gda_connection_execute_non_select_command (connection, del_query->str, &error);
#endif
However, midgard-core doesn't have a version requirement on GDA 4. If we remove this condition, we must ensure that it's built against GDA >= 4.2.3, similarly to what openSUSE did with gtranslator in this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This condition appears to be a relic from when GDA 3 was supported. The block containing the gda_sql_parser_new function in this file used to have this GDA 4 condition as well, but it doesn't anymore, meaning that it implicitly declares the function and converts it to a pointer when GDA 5 is used, as can be seen here.