add support for multiple services #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miketheman
requested changes
Aug 3, 2017
| @@ -65,5 +65,7 @@ def lambda_handler(event, context): | |||
|
|
|||
| # Valid event, and one we are interested in | |||
| cluster = event["detail"]["clusterArn"] | |||
| adjust_service_desired_count(ecs_client(), cluster, service) | |||
| serviceItems = service.split(',') | |||
| for item in serviceItems[:]: | |||
There was a problem hiding this comment.
I'm unfamiliar with the syntax of serviceItems[:] - can you explain how that is different from for item in serviceItems:?
| @@ -65,5 +65,7 @@ def lambda_handler(event, context): | |||
|
|
|||
| # Valid event, and one we are interested in | |||
| cluster = event["detail"]["clusterArn"] | |||
| adjust_service_desired_count(ecs_client(), cluster, service) | |||
| serviceItems = service.split(',') | |||
There was a problem hiding this comment.
Please remain consistent with the python naming convention of lower_case_with_underscores for variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for multiple services