-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: integration tests for PR pipeline #466
base: v1-migration
Are you sure you want to change the base?
Conversation
|
@@ -0,0 +1,24 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question - does this need its own tsconfig? Won't it just use the one used by packages/millicast-sdk
?
@gregdolby @Santiago-Souto @vishalkharge if you guys know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like it is reccomended for playwright. lhttps://playwright.dev/docs/test-typescript#tsconfigjson
packages/millicast-sdk/integration-tests/src/support-utils/utils.ts
Outdated
Show resolved
Hide resolved
packages/millicast-sdk/integration-tests/src/support-utils/generic.ts
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,78 @@ | |||
name: Integration Tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question(s) maybe for @vishalkharge
- This isn't running on a docker image, is it? It's running on GH runners, so should we be mindful of the number of tests and the number of re-tries we perform?
packages/millicast-sdk/integration-tests/features/connect.feature
Outdated
Show resolved
Hide resolved
When the "viewer1" selects simulcast layer with encodingId "0" | ||
Then the "viewer1" verifies video resolution for layer "0" | ||
|
||
When the "viewer1" selects simulcast layer with encodingId "1" | ||
Then the "viewer1" verifies video resolution for layer "1" | ||
|
||
When the "viewer1" selects simulcast layer with encodingId "2" | ||
Then the "viewer1" verifies video resolution for layer "2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of 0,1,2 this should be f,h,q
modifying to not require --testMatch for windows
Initial integration tests of WebSDK to be run in PR pipeline. Next steps are: