Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: integration tests for PR pipeline #466

Open
wants to merge 49 commits into
base: v1-migration
Choose a base branch
from
Open

Conversation

jwrobdolby
Copy link

@jwrobdolby jwrobdolby commented Oct 24, 2024

Initial integration tests of WebSDK to be run in PR pipeline. Next steps are:

  • create token before each run to avoid streamName conflicts
  • provide env variables used by tests
  • extend github workflow to run on rp2 and staging

Copy link

changeset-bot bot commented Oct 24, 2024

⚠️ No Changeset found

Latest commit: 94338b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -0,0 +1,24 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question - does this need its own tsconfig? Won't it just use the one used by packages/millicast-sdk ?

@gregdolby @Santiago-Souto @vishalkharge if you guys know?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it is reccomended for playwright. lhttps://playwright.dev/docs/test-typescript#tsconfigjson

@@ -0,0 +1,78 @@
name: Integration Tests
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question(s) maybe for @vishalkharge

  • This isn't running on a docker image, is it? It's running on GH runners, so should we be mindful of the number of tests and the number of re-tries we perform?

Comment on lines +16 to +23
When the "viewer1" selects simulcast layer with encodingId "0"
Then the "viewer1" verifies video resolution for layer "0"

When the "viewer1" selects simulcast layer with encodingId "1"
Then the "viewer1" verifies video resolution for layer "1"

When the "viewer1" selects simulcast layer with encodingId "2"
Then the "viewer1" verifies video resolution for layer "2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of 0,1,2 this should be f,h,q

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants