Processed review comment

minio · Apr 17, 2024 · 7ebad7b · 7ebad7b
1 parent 1875677
commit 7ebad7b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/internal/keystore/azure/error.go b/internal/keystore/azure/error.go
@@ -7,6 +7,7 @@ package azure
 import (
 	"encoding/json"
 	"errors"
+	"log/slog"
 
 	"github.com/Azure/azure-sdk-for-go/sdk/azcore"
 )
@@ -28,8 +29,9 @@ func transportErrToStatus(err error) (status, error) {
 	if errors.As(err, &rerr) {
 		var errorResponse errorResponse
 		if rerr.RawResponse != nil {
-			err = json.NewDecoder(rerr.RawResponse.Body).Decode(&errorResponse)
-			if err != nil {
+			jsonErr := json.NewDecoder(rerr.RawResponse.Body).Decode(&errorResponse)
+			if jsonErr != nil {
+				slog.Error("error deserializing Azure KeyVault error message: %v", jsonErr)
 				return status{}, err
 			}
 		}

diff --git a/internal/keystore/azure/key-vault.go b/internal/keystore/azure/key-vault.go
@@ -354,7 +354,7 @@ func (s *Store) purgeWithRetry(ctx context.Context, name string, retries int) (s
 			return stat, fmt.Errorf("azure: failed to delete '%s': %s (%s)", name, stat.Message, stat.ErrorCode)
 		}
 		switch {
-		case stat.StatusCode == http.StatusOK:
+		case stat.StatusCode == http.StatusOK || stat.StatusCode == http.StatusNotFound:
 			return stat, nil
 		case stat.StatusCode == http.StatusForbidden && stat.ErrorCode == "ForbiddenByPolicy":
 			return stat, nil