vault: improve Vault API interaction #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aead
force-pushed
the
vault-sdk
branch
2 times, most recently
from
4d7589f to
6946e60
Compare
This commit improves the Vault API interaction by using the `vaultapi.KVv1` and `vaultapi.KVv2` types where possible. This simplifies the `List`, `Delete` and `Get` APIs. Further, this commit changes the `List` API implementation by using HTTP GET instead of LIST. This is a workaround that prevents listing errors caused by some middleware/firewalls. Such systems may reject API calls with "non-standard" HTTP methods. Signed-off-by: Andreas Auernhammer <[email protected]>
shtripat
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the Vault API interaction by
using the
vaultapi.KVv1andvaultapi.KVv2types where possible. This simplifies theList,DeleteandGetAPIs.Further, this commit changes the
ListAPI implementation by using HTTP GET instead of LIST. This is a workaround that prevents listing errors caused by some middleware/firewalls. Such systems may reject API calls with "non-standard" HTTP methods.