Add Github Actions CI #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grosser
reviewed
Oct 31, 2023
grosser
reviewed
Oct 31, 2023
grosser
reviewed
Oct 31, 2023
grosser
reviewed
Oct 31, 2023
grosser
reviewed
Oct 31, 2023
grosser
reviewed
Oct 31, 2023
|
|
||
| self.readme_file = "README.rdoc" | ||
| self.history_file = "CHANGELOG.rdoc" | ||
|
|
||
| dependency "minitest", "~> 5.0" | ||
| dependency "rubocop", "~> 0.37", :dev | ||
| dependency "rubocop", "~> 1.57.0", :dev |
There was a problem hiding this comment.
previously that was in gemfile too
... either or is fine
FYI would recommend getting rid of hoe, just adds unnecessary indirection
There was a problem hiding this comment.
previously that was in gemfile too
ah, i understand now. the gemspec file is generated by hoe-gemspec, using the definition in Rakefile. the gemspec file is only here for the convenience of those using bundler to require the library via git, it is not used in packaging or deploying the gem
would recommend getting rid of hoe
ryan still prefers hoe, so i would expect it will stay for now
grosser
reviewed
Oct 31, 2023
blowmage
force-pushed
the
add-github-actions-ci
branch
2 times, most recently
from
01248f2 to
d307516
Compare
blowmage
force-pushed
the
add-github-actions-ci
branch
from
0bfbf54 to
802d156
Compare
grosser
reviewed
Oct 31, 2023
blowmage
force-pushed
the
add-github-actions-ci
branch
from
802d156 to
f3df209
Compare
blowmage
force-pushed
the
add-github-actions-ci
branch
2 times, most recently
from
308aa13 to
8494bd3
Compare
blowmage
force-pushed
the
add-github-actions-ci
branch
from
8494bd3 to
7b76b9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.