-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #815
Update dependencies #815
Conversation
6fde036
to
dab6333
Compare
Thanks for your changes, from what I can tell the issue is changes in 4.4.0. If you apply the following patch, it should work: --- a/mirage/config.ml
+++ b/mirage/config.ml
@@ -202,10 +202,18 @@ let enable_metrics =
let doc = Key.Arg.info ~doc:"Enable metrics reporting" [ "metrics" ] in
Key.(create "metrics" Arg.(flag doc))
+type i0 = I0
+let i0 = Functoria.Type.v I0
+let no0 = Functoria.impl "Int" job
+
+type n1 = N1
+let n1 = Functoria.Type.v N1
+let noop1 = Functoria.impl "Set.Make" (job @-> job)
+
let optional_monitoring time pclock stack =
if_impl (Key.value enable_metrics)
(mirage_monitoring $ time $ pclock $ stack)
- noop
+ (noop1 $ no0)
let () =
register "www" |
Yes, I was going to ask you :) wouldn't have figured that out! |
Dockerfile
Outdated
RUN opam repo add mirage-dev git+https://github.com/mirage/mirage-dev.git#842c55556ffd0950d21141d6ab99e52a8d88a50f | ||
RUN sudo ln -f /usr/bin/opam-2.1 /usr/bin/opam && cd ~/opam-repository && git pull origin master && git reset --hard 30b1b97d735732e40996cf2e6b06d478ac40633f && opam update | ||
RUN opam pin tailwindcss.dev https://github.com/tmattio/opam-tailwindcss/archive/3e60fc32bbcf82525999d83ad0f395e16107026b.tar.gz | ||
RUN opam repo add mirage-dev git+https://github.com/mirage/mirage-dev.git#749c02302f8f15e609332edbe827541558554a80 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this mirage-dev
overlay we should not need (famous last words) at all ;)
Maybe the mirage tool should be relaxed to allow some jobs without arguments (maybe exactly the noop job) -- but the mirage repository is currently in unclear state -- the main branch isn't too usable, we could continue on the 4.4 branch... |
|
Erk, the deployer is using mirage 3… I think this PR is exceeding on the time I wanted to allocate for this, haha. |
For the patch posted above, here is a fix for the mirage utility mirage/mirage@16e82ff |
That's a bit sad. Well, I don't quite understand the whole "CI" and "deployment" stuff of this repository anyways... Eventually someone will (hopefully) fix it. Even a local build doesn't work for me (as mentioned in #792). |
3f58104
to
85a8348
Compare
b577d1f
to
0488633
Compare
CHANGES: - Fix GC documentation (space overhead is 120 since best-fit is default) (mirage/mirage#1491 @hannesm) - use Option in printing of GC keys (mirage/mirage#1491 @hannesm) - allow to use git 3.15 (mirage/mirage#1491 @hannesm) - allow empty noop job (addresses an issue with mirage/mirage#1428) solves an issue reported by @MisterDA in mirage/mirage-www#815 (mirage/mirage#1491 @hannesm)
I wanted to raise my voice that since mirage 4.4.2 got released, the above diff is not needed anymore. Not sure whether this makes any difference for this PR (which seems abandoned). |
Hi Hannes, |
Thanks, some of your changes have been picked by #818 and now the CI is green again! |
CHANGES: - Fix GC documentation (space overhead is 120 since best-fit is default) (mirage/mirage#1491 @hannesm) - use Option in printing of GC keys (mirage/mirage#1491 @hannesm) - allow to use git 3.15 (mirage/mirage#1491 @hannesm) - allow empty noop job (addresses an issue with mirage/mirage#1428) solves an issue reported by @MisterDA in mirage/mirage-www#815 (mirage/mirage#1491 @hannesm)
No description provided.