Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump actions/checkout from 3 to 4" #20

Merged

Conversation

riccardoporreca
Copy link
Member

@riccardoporreca riccardoporreca commented Jan 24, 2024

Reverts #18, which was auto-merged via @dependabot merge and this caused the workflows run on the merge commit to havegithub.actor == "dependabot[bot]", which does have access to secrets, thus braking the deployments to shinyapps.io as unauthorized

See dependabot/dependabot-core#3253 and in particular
dependabot/dependabot-core#3253 (comment)

Why does @dependabot merge fail on a push event?

The github.actor == "dependabot[bot]" since you have asked Dependabot to do the merge (vs a human actor).

We don't recommend commenting @dependabot merge to automerge a PR.

There is a clear message about not using @dependabot merge, which we should adhere to.

@riccardoporreca
Copy link
Member Author

@GuidoMaggio, @RolandASc, can any of you please approve this?

The plan is to revert the merge commit from dependabot and then let dependabot re-open a PR for the same upgrade, which will be merged manually w/o @dependabot merge

Copy link
Member

@GuidoMaggio GuidoMaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@riccardoporreca riccardoporreca merged commit 176d019 into master Jan 24, 2024
4 checks passed
@riccardoporreca riccardoporreca deleted the revert-18-dependabot/github_actions/actions/checkout-4 branch January 24, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants