-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit for switching to pyproject.toml #30
Conversation
Maybe a bit more elaboration on two topics:
|
Forgot to add @davide-vitiello as well per his request in the issue. |
Hi @mirai-mjelavic , regarding the two open points about MANIFEST and TOX, I think we can defer them to later. |
…ge of pyproject.toml
I have changed the publish.yml following this guide with testpypi as well -> https://packaging.python.org/en/latest/tutorials/packaging-projects/ https://test.pypi.org/project/secretsanta/0.1.0/ contains the end result. |
@mirai-mjelavic , I suppose the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks good to me, maybe one last small thing to already increment the version as an upcoming development version?
Migration from setup.py to pyproject.toml.
I have not managed to find a way to migrate MANIFEST.in, or tox since it uses some legacy parser in pyproject.toml which throws errors.
.coveragerc could be moved to pyproject.toml but we use the file itself within tox.ini so I don't know how we would handle reading the coverage configuration from toml as part of tox.
Open to all suggestions and to learn more, have been wrestling myself with some of these errors but unsuccessfully. Also open to using a different build-backend if you prefer.