migration to sea_orm + polar rules rework + endpoint logic rework #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #4 |
fairingrey
force-pushed
the
new-polar
branch
from
58ceb6c to
218aae2
Compare
k-cross
approved these changes
Feb 17, 2022
fairingrey
force-pushed
the
new-polar
branch
from
a85ab9c to
585542a
Compare
k-cross
reviewed
Feb 18, 2022
fairingrey
force-pushed
the
new-polar
branch
from
e18b96a to
c0d79f6
Compare
|
What's left to do is to essentially migrate the rest of the sqlx code to sea_orm calls, clean up any leftover bits of logic (in particular with the polar policy files), and then we can finally get started on cracking at the frontend. And yeah, this PR will be rebased since my commit history is obviously dirty here (albeit it doesn't really matter that much) |
fairingrey
force-pushed
the
new-polar
branch
from
ef45b65 to
ecdeadd
Compare
move entities rework polar rules buncha other changes rework rules and endpoint logic fix role assn remove unused imports fix oso query, result might be error update deps super thicc diff too many changes to document, but basically reworking to use SeaORM WIP dumb mistake WIP bloop don't actually need the extra ref more WIP don't program when tired seriously, DONT PROGRAM WHEN TIRED fix remove custom-derive, use fieldfilter WIP adjust rules to work with new pclasses impl update_user handler finish user handlers rewrite finish rework whoops
fairingrey
force-pushed
the
new-polar
branch
from
bc15b75 to
0434463
Compare
fairingrey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit raw and dirty, but feels more 'idiomatic' and rustic.
About why
UserFilterisn't a polar class is probably because it would limit policy flexibility -- in that while it is possible to construct new Rust polarclass structs within polar and then query for those structs via the rules that match, it would make it difficult to resolve queries where multiple rules can match (and thus there would need to be some sort of merge resolution/logic).This approach, where
allow_fieldrules are kept butHashSet<String>types can be converted into some pattern ofEntityOptionalby way of anEntityFilteris probably fine for now. I do feel as if there might be a few ways to macro the repetitive logic, but otherwise it's not a huge deal. More importantly the endpoint logic is a lot more sane and readable.