Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added field for Name module #871

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

ajstanley
Copy link
Contributor

Issue 839

What does this PR do?

Allows use of names formatted by the name module to be included in ingests and serializations.

What changes were made?

Created a new field class and added existence checks.

How to test / verify this PR?

Testing.
Add name module to an Islandora instance with composer require 'drupal/name:^1.0'
Add name field to your content model.
Add name data to a workbench create or update sheet.
Each name consists of the following values
['title', 'given', 'middle', 'family', 'generational', 'credentials'], any of which may be blank.

The following names are all valid.

  • Mr:John:Franklin:McDonald:II:Ph.d
  • :John:Franklin:McDonald:II:Ph.d
  • :John::McDonald::Ph.d
  • :John::McDonald::

Each entry should have five colons.

Interested Parties

**@mjordan, @rosiel ** - name some folks who may be interested, or, if unsure, @mjordan


Checklist

  • Before opening this PR, have you opened an issue explaining what you want to to do?
  • Have you included some configuration and/or CSV files useful for testing this PR?
  • Have you written unit or integration tests if applicable?
  • Does the code added in this PR require a version of Python that is higher than the current minimum version?
  • If the changes in this PR require an additional Python library, have you included it in setup.py?
  • If the changes in this PR add a new configuration option, have you provided a default for when the option is not present in the .yml file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants