Skip to content

Commit

Permalink
Reset terminationGracePeriodSeconds for SM Pods (submariner-io#50)
Browse files Browse the repository at this point in the history
In one of the earlier PRs, we modified the terminationGracePeriodSeconds
to 10 secs. However, its seen that this is causing more CI failures
during e2e redundancy tests. Ideally, once the Pods are terminated,
it should cleanup itself ASAP but it is seen that SM Pods are sometimes
taking time to exit and during this Period since there is no active SM
Pod running, this is triggering some failures.

Until we figure out the exact reason why the Pods are taking time for
cleanup, this PR reduces the terminationGracePeriodSeconds.

This issue would be properly addressed via
submariner-io/submariner#694

Signed-Off-by: Sridhar Gaddam <[email protected]>
  • Loading branch information
sridhargaddam authored Jul 10, 2020
1 parent fb65f1f commit 7cc50b0
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion submariner/templates/engine-deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -130,5 +130,5 @@ spec:
restartPolicy: Always
schedulerName: default-scheduler
securityContext: {}
terminationGracePeriodSeconds: 10
terminationGracePeriodSeconds: 1
serviceAccountName: {{ template "submariner.engineServiceAccountName" . }}
2 changes: 1 addition & 1 deletion submariner/templates/globalnet.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ spec:
hostNetwork: true
serviceAccountName: submariner-globalnet
serviceAccount: submariner-globalnet
terminationGracePeriodSeconds: 10
terminationGracePeriodSeconds: 2
nodeSelector:
submariner.io/gateway: 'true'
containers:
Expand Down
2 changes: 1 addition & 1 deletion submariner/templates/route-agent-ds.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ spec:
component: routeagent
spec:
serviceAccountName: {{ template "submariner.routeAgentServiceAccountName" . }}
terminationGracePeriodSeconds: 10
terminationGracePeriodSeconds: 1
hostNetwork: true
containers:
- name: routeagent
Expand Down

0 comments on commit 7cc50b0

Please sign in to comment.