[Web] Set TOKENIZERS_PARALLELISM to false for HFTokenizer #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 12, 2024
CharlieFRuan
added a commit
to mlc-ai/web-llm
that referenced
this pull request
Aug 12, 2024
### Changes - Reorganized internal code, which should have no affect on behaviors #536 - Bumped version of tokenizers-cpp to fix potential error `The global thread pool has not been initialized.` - For more, see mlc-ai/tokenizers-cpp#42 ### TVMjs - Still compiled at apache/tvm@1fcb620, no change
jzhao62
pushed a commit
to jzhao62/web-llm
that referenced
this pull request
Dec 8, 2024
### Changes - Reorganized internal code, which should have no affect on behaviors mlc-ai#536 - Bumped version of tokenizers-cpp to fix potential error `The global thread pool has not been initialized.` - For more, see mlc-ai/tokenizers-cpp#42 ### TVMjs - Still compiled at apache/tvm@1fcb620, no change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For certain
tokenizer.json, huggingface's tokenizer would try to use thread parallelism, leading to error in wasm runtime. This PR setsTOKENIZERS_PARALLELISMtofalsewhen compiling for web, whichhuggingface/tokenizersreads in runtime.See mlc-ai/mlc-llm#2601 for more.