Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not raise when model version path is s3 #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not raise when model version path is s3 #101

wants to merge 1 commit into from

Conversation

richardyc
Copy link

@richardyc richardyc commented Mar 27, 2023 •
edited
Loading

#73

@richardyc richardyc marked this pull request as ready for review March 27, 2023 14:21
@richardyc richardyc changed the title Do not raise when model version path starts with s3 Do not raise when model version path is s3 Mar 27, 2023
@richardyc richardyc force-pushed the importversions3fix branch from 274bf59 to 5559721 Compare March 27, 2023 14:26
mick-graft
mick-graft approved these changes May 9, 2023
View reviewed changes
Copy link

@mick-graft mick-graft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luchetto81
Copy link

Hi Everyone,
is there any chance this bug fix is going to be merged and released?
Thanks so much in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mick-graft mick-graft mick-graft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richardyc @luchetto81 @mick-graft