Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MLTE-552 - Custom List File System Store #577

Merged
merged 22 commits into from
Jan 14, 2025
Merged

MLTE-552 - Custom List File System Store #577

merged 22 commits into from
Jan 14, 2025

Conversation

sei-aderr
Copy link
Collaborator

No description provided.

sei-secheverria
sei-secheverria requested changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@sei-secheverria sei-secheverria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly ok, a couple minor things to improve.

mlte/custom_list/custom_list_names.py Outdated Show resolved Hide resolved
mlte/store/custom_list/qa_categories/fairness.json Outdated Show resolved Hide resolved
mlte/store/custom_list/quality_attributes/__init__.py Outdated Show resolved Hide resolved
mlte/store/custom_list/store_session.py Outdated Show resolved Hide resolved
mlte/store/custom_list/underlying/fs.py Outdated Show resolved Hide resolved
mlte/store/custom_list/initial_custom_lists.py Outdated Show resolved Hide resolved
test/store/custom_list/test_underlying.py Outdated Show resolved Hide resolved
@sei-aderr sei-aderr merged commit 324dc8e into mlte-505 Jan 14, 2025
9 checks passed
@sei-aderr sei-aderr deleted the mlte-552 branch January 14, 2025 20:44
@sei-aderr sei-aderr mentioned this pull request Jan 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sei-secheverria sei-secheverria sei-secheverria approved these changes

@sebastian-echeverria sebastian-echeverria Awaiting requested review from sebastian-echeverria

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sei-aderr @sei-secheverria