Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travel Restrictions xml settings #1008

Closed
wants to merge 5 commits into from

Conversation

DragonSlayer62
Copy link

This adds the abilities to be able to edit the restrictions of travel on the fly without having to get into the spell helper.

The old system in spellhelper.cs will need to be removed so there is no conflicts.

This adds the abilities to be able to edit the restrictions of travel on the fly without having to get into the spell helper.

The old system in spellhelper.cs will need to be removed so there is no conflicts.
@CLAassistant
Copy link

CLAassistant commented Apr 26, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ kamronbatman
❌ DragonSlayer62
You have signed the CLA already but the status is still pending? Let us recheck it.

@@ -80,6 +83,116 @@ public static class SpellHelper
1, 1
};

public static void Configure()
{// Custom Travel Settings. Needs converted to Json in time.
Console.Write("SpellHelper: Loading TravelRestrictions...");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change this to use logger.

@kamronbatman kamronbatman reopened this Apr 26, 2022
@kamronbatman
Copy link
Contributor

Let's focus on eliminating travel restrictions entirely and put the properties directly on the regions.

@kamronbatman
Copy link
Contributor

Let's discuss this on #1733 and revisit this with a better implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants