Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable External bulk TTK deployment test #2814

Closed
35 tasks done
PaulGregoryBaker opened this issue Jul 6, 2022 · 3 comments
Closed
35 tasks done

Enable External bulk TTK deployment test #2814

PaulGregoryBaker opened this issue Jul 6, 2022 · 3 comments
Assignees
@vijayg10 @PaulGregoryBaker
Labels
core-dev-squad oss-bulk Mojaloop bulk implementation and support oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it story
Milestone
Sprint 19.2

Comments

@PaulGregoryBaker
Copy link

PaulGregoryBaker commented Jul 6, 2022 •
edited by vijayg10
Loading

Goal:

As a hub operator
I want to like to know that my Mojaloop hub deployment is configured to support bulk transfers
so that I can be confident in the service that I provide to participants.

Note:

  • As this test needs to be through the API gateway with security enabled. This is more easily achieved by modifying an existing PM4ML deployment with TTK configured to call the SDK-Scheme-Adapter's backend API's
  • The design for this deployment is covered here
    • This story does not include the exposed TTK web socket to be used in the test case validations.
    • This means that the tests run are limited in what they can test. I.e. they can only assert on the responses of the test calls made as there will be no way of asserting against the Payee DFSP
    • This also means that the not all the functionality can be tested using this test set. This is not a problem because this test is to be use in conjunction with the internal TTK bulk test which are able to test the full deployed bulk functionality.
      I.e. The full golden path bulk test that check all scenarios is run internally and compliments this testing story

Acceptance Criteria:

  • Verify that an external (though API gateway) Payer DFSP is able to send a bulk message with full security enabled
    • bulk quotes
    • bulk transfers
  • Verify that an external (though API gateway) Payee DFSP is able to send a bulk message with full security enabled
    • bulk quotes
    • bulk transfers

Complexity: <High|Medium|Low> > A short comment to remind the reason for the rating
Uncertainty: <High|Medium|Low> > A short comment to remind the reason for the rating

Tasks:

  • Include TTK with core connector API provisioned and corresponding simulation rules configured
    • Point TTK to sdk-scheme-adapter backend API endpoint
    • Upgrade SDK Backend API
    • Add response rules for simulated response (Payee DFSP side)
    • Provision default environment file
    • Provision the git repo in the configuration to show the repo in UI to download testcases
    • Expose TTK Ingress endpoints
  • Switch the BACKEND_ENDPOINT in sdk-scheme-adapter to TTK instead of core connector
  • Add 'TTK_Enabled' and 'TTK_AS_CoreConnectorBackend' parameter to PM4ML Helm
  • IaC Tasks:
    • Add 'TTK_Enabled' and 'TTK_AS_CoreConnectorBackend' to IaC configuration
    • Upgrade the helm chart in IaC
    • Supply new Ingress endpoints (TTK ingress endpoints)
    • Check the PM4ML Postman on-boarding collection of bulk support (e.g. bulk endpoints, ...)
    • Add GitLab Job for the tests (this is the preferred option; the alternative is to run manually)

Done

  • Acceptance Criteria pass
  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.
  • TBD

Pull Requests:

New Releases:

Fixed Issues:

Followup Stories:

  • SDK-scheme-adapter is not updating the jws certificates of new FSP onboarded
    • Fix: There are stories for this issue mojaloop/2841 mojaloop/3264
    • Workaround: Restart the sdk-scheme-adapter pod incase if it couldn't get the latest JWS certificates
  • JWS validation is failing in the ttkpm4mlreceiver because switch is modifying the bulk requests. Need to turn of it in sdk-schame-adapter config
    • Fix: Created a story for this mojaloop/2867 [COMPLETED]
    • Workaround: Disable JWS in pm4mls for testing bulk
  • SDK Scheme Adaptor: Some issue in the sdk outbound bulk handler. await this._requests.postBulkTransfers(bulkTransferPrepare, this.data.from.fspId); The last field here should be toId instead of fromId.
    • fix: Created a bug mojaloop/2891
    • Workaround: Specify from.fspId in the test request
  • TLS is not configurable in TTK helm chart due to some bug in TTK helm chart
    • Fix: Created a story to fix the TTK helm chart mojaloop/2860
    • Workaround: Disable TLS for the TTK ingress in pm4ml as this is only for testing

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC
@PaulGregoryBaker PaulGregoryBaker added core-dev-squad oss-bulk Mojaloop bulk implementation and support oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it story to-be-refined This story is ready to be groomed labels Jul 6, 2022
@PaulGregoryBaker PaulGregoryBaker changed the title Enable External bulk TTK happy path test Enable External bulk TTK deployment test Jul 25, 2022
@PaulGregoryBaker PaulGregoryBaker mentioned this issue Jul 27, 2022
Closed
15 tasks
@PaulGregoryBaker PaulGregoryBaker removed the to-be-refined This story is ready to be groomed label Jul 29, 2022
@vijayg10
Copy link

vijayg10 commented Aug 9, 2022

Found a bug in TTK helm chart while trying to deploy it in PM4ML. Logged the bug here #2860

@vijayg10 vijayg10 mentioned this issue Aug 15, 2022
Merged
@vijayg10 vijayg10 mentioned this issue Aug 24, 2022
Merged
@vijayg10
Copy link

vijayg10 commented Aug 24, 2022 •
edited
Loading

Use the following TTK testcase and rules file for testing bulk.
bulk-test-ttk.zip

vijayg10 added a commit to pm4ml/mojaloop-payment-manager-helm that referenced this issue Aug 24, 2022
@vijayg10
feat(mojaloop/2814): bumped up ttk, sdk and changed ttk config (#128)
fcb68f8 
feat(mojaloop/2814): bumped up ttk, sdk and changed ttk config, closes the story [mojaloop/2814](mojaloop/project#2814)
* bumped up ttk and changed ttk config
* chore: bump up sdk version
* bump up version in charts file
@elnyry-sam-k elnyry-sam-k added this to the Sprint 19.2 milestone Aug 25, 2022
@vijayg10
Copy link

This is the recording of the test

GMT20220829-124738_Recording_1920x1080.mp4

@vijayg10 vijayg10 mentioned this issue Feb 6, 2023
Closed
21 tasks
@PaulGregoryBaker PaulGregoryBaker mentioned this issue Feb 6, 2023
Closed
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vijayg10 vijayg10

@PaulGregoryBaker PaulGregoryBaker

Labels
core-dev-squad oss-bulk Mojaloop bulk implementation and support oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it story
Projects
None yet
Milestone
Sprint 19.2
Development

No branches or pull requests
4 participants
@elnyry-sam-k @vijayg10 @PaulGregoryBaker @chris-me-law