Fix/translation error in blocks #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhuesken
requested changes
Jan 20, 2025
src/Gateway/MolliePaymentGateway.php
Outdated
| // Load the settings. | ||
| $this->init_form_fields(); | ||
| // Load the settings when translations are ready | ||
| add_action('after_setup_theme', [$this, 'init_form_fields']); |
| @@ -61,6 +65,8 @@ public function __construct( | |||
| $this->config = $this->getConfig(); | |||
| $this->settings = $this->getSettings(); | |||
| $this->apiPaymentMethod = $apiPaymentMethod; | |||
| add_action('after_setup_theme', [$this, 'initializeTranslations']); | |||
There was a problem hiding this comment.
I think better is to use init
danielhuesken
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves an issue where the Mollie methods in blocks appeared as non compatible. This was due to the change in the init hook. Now we are back to the
plugins_loadedhook. To avoid the translations called too early issue the payment fields were moved to a later hookafter_setup_theme