feat: throw error if duplicate map

apps/backend-e2e/src/maps.e2e-spec.ts

@@ -1230,6 +1230,30 @@ describe('Maps', () => {
           });
         });
 
+        it('should throw 409 Conflict if map with same BSP hash is submitted again', async () => {
+          await uploadBspToPreSignedUrl(bspBuffer, token);
+
+          await req.postAttach({
+            url: 'maps',
+            status: 201,
+            data: createMapObject,
+            token
+          });
+
+          await uploadBspToPreSignedUrl(bspBuffer, token);
+
+          const res = await req.postAttach({
+            url: 'maps',
+            status: 409,
+            data: createMapObject,
+            token
+          });
+
+          expect(res.body.message).toBe(
+            'Map with this file hash already exists'
+          );
+        });
+
         it('should succeed if VMF file is missing', async () => {
           await uploadBspToPreSignedUrl(bspBuffer, token);
 
@@ -2325,6 +2349,26 @@ describe('Maps', () => {
         });
       });
 
+      it('should throw 409 Conflict if map with same BSP hash is submitted again', async () => {
+        await uploadBspToPreSignedUrl(bspBuffer, u1Token);
+
+        await req.postAttach({
+          url: `maps/${map.id}`,
+          status: 201,
+          data: {},
+          token: u1Token
+        });
+
+        const res = await req.postAttach({
+          url: `maps/${map.id}`,
+          status: 409,
+          data: {},
+          token: u1Token
+        });
+
+        expect(res.body.message).toBe('Map with this file hash already exists');
+      });
+
       for (const status of [MapStatus.APPROVED, MapStatus.DISABLED]) {
         it(`should 403 if the map status is ${MapStatus[status]}`, async () => {
           await prisma.mMap.update({ where: { id: map.id }, data: { status } });

apps/backend/src/app/modules/maps/maps.service.ts

@@ -552,6 +552,15 @@ export class MapsService {
     const hasVmf = vmfFiles?.length > 0;
     const bspHash = FileStoreService.getHashForBuffer(bspFile.buffer);
 
+    // Check for duplicate map hash
+    const existingMap = await this.db.mMap.exists({
+      where: { versions: { some: { bspHash } } }
+    });
+
+    if (existingMap) {
+      throw new ConflictException('Map with this file hash already exists');
+    }
+
     let map: Awaited<ReturnType<typeof this.createMapDbEntry>>;
 
     const tasks: Promise<any>[] = [
@@ -661,6 +670,15 @@ export class MapsService {
     const hasVmf = vmfFiles?.length > 0;
     const bspHash = FileStoreService.getHashForBuffer(bspFile.buffer);
 
+    // Check for duplicate map hash
+    const existingMap = await this.db.mMap.exists({
+      where: { versions: { some: { bspHash } } }
+    });
+
+    if (existingMap) {
+      throw new ConflictException('Map with this file hash already exists');
+    }
+
     let zonesStr: string;
     let zones: MapZones;
     if (dto.zones) {

docker-compose.test.yml

@@ -1,5 +1,3 @@
-version: '3.8'
-
 services:
   postgres:
     environment: &env

docker-compose.yml

@@ -1,5 +1,3 @@
-version: '3.8'
-
 services:
   postgres:
     container_name: postgres