Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ionutchioran/feature #5

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

chioranionutcatalin
Copy link

@chioranionutcatalin chioranionutcatalin commented Nov 21, 2022

Added more info into the readme file. the DS file and the package lock might not be needed.


);
//TO.DO: Create the business component that hides agnostic component also for product details and for product estimated value.
const MortgageSection = ({currentBalance, name, handleClickMortgage}) => (
Copy link
Author

@chioranionutcatalin chioranionutcatalin Nov 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could also wrap the other sections like this one to not put directly <TitledList /> in the main component

return (
<AccountSection>
<AccountLabel>Valuation change</AccountLabel>
<SectionWrapper>
Copy link
Author

@chioranionutcatalin chioranionutcatalin Nov 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used this <SectionWrapper> to add the other col without modifying too much the initial components

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants