Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use dark colors for background on initial app loading with dark theme #4980

Merged
merged 4 commits into from
Nov 1, 2023
Merged

feat: use dark colors for background on initial app loading with dark theme #4980

merged 4 commits into from
Nov 1, 2023

Conversation

efficientwrite
Copy link
Contributor

Description

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@addaleax
Copy link
Collaborator

(merged main to account for a fix that un-breaks CI – thank you for the PR!)

@Anemy Anemy changed the title For dark theme, use dark colors for background on initial app loading feat: use dark colors for background on initial app loading with dark theme Oct 19, 2023
@Anemy Anemy merged commit 8c74849 into mongodb-js:main Nov 1, 2023
@Anemy
Copy link
Member

Anemy commented Nov 2, 2023

@gokulraam Thanks again for the PR! This'll be in the next release of Compass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anemy Anemy Anemy approved these changes

Assignees
No one assigned
Labels
feat release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@efficientwrite @addaleax @Anemy @gokulraam