chore(compass-editor): refactor JSON editor actions container into its own component #6441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
added
the
no-title-validation
kraenhansen
force-pushed
the
kh/refactor-editor-actions
branch
from
224314b to
306b116
Compare
kraenhansen
commented
Nov 4, 2024
| @@ -14,3 +14,16 @@ export type CompletionWithServerInfo = { | |||
| /** Optional completion description */ | |||
| description?: string; | |||
| }; | |||
|
|
|||
| export type EditorRef = { | |||
There was a problem hiding this comment.
Moved this here to be able to reference it from both editor.tsx and actions-container.tsx without introducing a circular import dependency.
kraenhansen
commented
Nov 4, 2024
| @@ -1537,7 +1468,7 @@ const MultilineEditor = React.forwardRef<EditorRef, MultilineEditorProps>( | |||
| className={cx( | |||
| multilineEditorContainerStyle, | |||
| darkMode && multilineEditorContainerDarkModeStyle, | |||
| !!actions.length && multilineEditorContainerWithActionsStyle, | |||
| hasActions && multilineEditorContainerWithActionsStyle, | |||
There was a problem hiding this comment.
The actions.length was actually always > 0, since we didn't trim the array from false values that could arise from the copyable or formattable being false.
kraenhansen
force-pushed
the
kh/refactor-editor-actions
branch
2 times, most recently
from
216642b to
409137a
Compare
kraenhansen
force-pushed
the
kh/refactor-editor-actions
branch
from
409137a to
fe4442e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a preparation for COMPASS-4635 this refactors the JSON editor, extracting the actions container into its own component. This refactor brings no additional features or visual changes.
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes