Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(NODE-6358): perf test against current branch #713

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Conversation

durran
Copy link
Member

@durran durran commented Sep 3, 2024

Description

Updates benchmarks to run against current branch.

What is changing?

  • Sets LIBRARY in the environment to the current working directory.
  • Updates dbx-js-tools to latest.
  • Removes the Node version from the bench task names.

NOTE this PR will clear perf benchmark history.

Here's a run pointing at mongodb-js/dbx-js-tools#20

https://spruce.mongodb.com/task/node_bson_perf_run_granular_benchmarks_patch_426c781b3f944bb100a3e70268f3a17210a1178f_66d87ce9c5ee6b0007ef93c4_24_09_04_15_29_49/logs?execution=0

That PR merged, new PR here:

https://spruce.mongodb.com/task/node_bson_perf_run_granular_benchmarks_patch_886391587154866befadc8dd44110411ed54d1ff_66d8e533246d3100075d3bec_24_09_04_22_54_45/logs?execution=0

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-6358

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran force-pushed the NODE-6358 branch 5 times, most recently from f4ca39c to 83f79b2 Compare September 4, 2024 15:29
package.json Outdated Show resolved Hide resolved
@durran durran marked this pull request as ready for review September 4, 2024 15:37
@nbbeeken nbbeeken self-assigned this Sep 4, 2024
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Sep 4, 2024
@nbbeeken nbbeeken self-requested a review September 4, 2024 15:57
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the other PR merges

@nbbeeken nbbeeken merged commit 5a8900e into main Sep 5, 2024
8 checks passed
@nbbeeken nbbeeken deleted the NODE-6358 branch September 5, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants