CSHARP-5429: Support strings with range operator for atlas search #1588
Conversation
| /// <param name="value">The value.</param> | ||
| /// <returns>StringSearchRange.</returns> | ||
| public static StringSearchRange Lt(this StringSearchRange stringSearchRange, string value) | ||
| => new(stringSearchRange.Min, max: value, stringSearchRange.IsMinInclusive, false); |
There was a problem hiding this comment.
Better add the name of the last parameter name, so it's easier to understand what's happening here.
| /// <param name="value">The value.</param> | ||
| /// <returns>StringSearchRange.</returns> | ||
| public static StringSearchRange Lte(this StringSearchRange stringSearchRange, string value) | ||
| => new(stringSearchRange.Min, max: value, stringSearchRange.IsMinInclusive, true); |
| @@ -611,6 +611,33 @@ public SearchDefinition<TDocument> Range<TField>( | |||
| SearchScoreDefinition<TDocument> score = null) | |||
| where TField : struct, IComparable<TField> => | |||
| new RangeSearchDefinition<TDocument, TField>(path, range, score); | |||
|
|
|||
There was a problem hiding this comment.
You're missing a constructor that takes Expression<Func<TDocument, IEnumerable<TField>>> for path, and a relative test
There was a problem hiding this comment.
I already added this in another PR that was merged. I just need to rebase my current PR to show that.
There was a problem hiding this comment.
Maybe I'm missing something but I mean another constructor with this signature:
public SearchDefinition<TDocument> Range<TField>(
Expression<Func<TDocument, IEnumerable<TField>>> path,
StringSearchRange range,
SearchScoreDefinition<TDocument> score = null)
This is so that the constructor can be used when the field is an IEnumerable
There was a problem hiding this comment.
Oh I thought you were mentioning it for other Range methods that use SearchRange. So for the new Range overloads using StringSearchRange, we don't need another overload with IEnumerable<TField> since TField isn't used anywhere else for the parameters. So if a user uses a field that is an IEnumerable, TField would be an IEnumerable.
There was a problem hiding this comment.
My bad! You're right, in this case we got no parameters.
adelinowona
force-pushed
the
csharp5429
branch
from
b75f463 to
8fa028b
Compare
No description provided.