CSHARP-5446: Linq Aggregte Group(...) not support AddToSet #1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanych-sun
requested review from
BorisDog and
rstam
and removed request for
a team and
BorisDog
rstam
requested changes
Jan 23, 2025
| case AstUnaryOperator.Avg: accumulatorOperator = AstUnaryAccumulatorOperator.Avg; return true; | ||
| case AstUnaryOperator.First: accumulatorOperator = AstUnaryAccumulatorOperator.First; return true; | ||
| case AstUnaryOperator.Last: accumulatorOperator = AstUnaryAccumulatorOperator.Last; return true; | ||
| case AstUnaryOperator.Max: accumulatorOperator = AstUnaryAccumulatorOperator.Max; return true; | ||
| case AstUnaryOperator.Min: accumulatorOperator = AstUnaryAccumulatorOperator.Min; return true; | ||
| case AstUnaryOperator.Push: accumulatorOperator = AstUnaryAccumulatorOperator.Push; return true; | ||
| case AstUnaryOperator.SetUnion: accumulatorOperator = AstUnaryAccumulatorOperator.AddToSet; return true; |
There was a problem hiding this comment.
You should add a similar mapping for SetIntersection.
Even if we aren't currently generating any MQL with SetIntersection it's a valid optimization.
SetUnion and SetIntersection with a single argument (i.e. the unary versions) are equivalent.
| @@ -786,8 +786,8 @@ public void IGrouping_Distinct_of_root_should_work() | |||
| var stages = Translate(collection, queryable); | |||
| var expectedStages = new[] | |||
| { | |||
| "{ $group : { _id : '$_id', _elements : { $push : '$$ROOT' } } }", // MQL could be optimized further | |||
There was a problem hiding this comment.
MQL could be optimized further! :)
And now it is.
sanych-sun
changed the title
sanych-sun
force-pushed
the
csharp5446
branch
from
1ce73a1 to
24308cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.