Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-6407): use conversationId returned from server in saslContinue #4368

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Jan 14, 2025

Description (copied from #4258)

MONGODB-AWS authentication mechanism should follow SASL spec. Current implementation ignores the conversationId sent by the server and uses a hardcoded integer for all saslContinue messages across all conversations.

What is changing?

  • Changing the hardcoded integer for conversationId to utilize the one that gets returned in the saslStart response.
  • Add integration test to verify that saslContinue uses the conversationId returned by saslStart
Is there new documentation needed for these changes?

No. This change brings the implementation to spec.

What is the motivation for this change?

This is a bug. MONGODB-AWS authentication failed on database emulating MongoDB.

Release Highlight

Fixes SASL implementation for MONGODB-AWS to use conversationId returned by the server instead of hardcoded integer.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants