Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gov Revisions #1071

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Gov Revisions #1071

merged 3 commits into from
Jan 14, 2025

Conversation

themacexpert
Copy link
Contributor

Description

Some snippets got deleted in a prior PR, this restores them but rather than re-creating the snippets, adds them directly to the text.

Checklist

  • I have added a label to this PR 🏷️
  • I have run my changes through Grammarly
  • If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira
  • If pages have been moved around, I have created an additional PR in moonbeam-mkdocs to update redirects
  • If pages have been moved around, I have run the move-pages.py script to move the pages and update the image paths on the chinese repo
    • After the script has been run, I have created an additional PR in moonbeam-docs-cn
  • If images have been added, I have run the compress-images.py script to compress the images.
  • If variables (in variables.yml) need to be updated (such as a name change), I have updated the moonbeam-docs-cn repo to use the new variables
  • If this page requires a disclaimer, I have added one

Corresponding PRs

Please link to any corresponding PRs here.

After Translation Requirements

  • Will need to create PR in moonbeam-docs repo to remove images
  • Will need to create PR in moonbeam-docs repo to remove variables
  • Will need to create PR in moonbeam-mkdocs repo to add redirects for Chinese site
  • No additional PRs are required after the translations are done

Items to be Updated

Please list any of the items that will need to be added or deleted after the translations are done here.

@themacexpert themacexpert added A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) B0 - Needs Review Pull request is ready for review labels Jan 10, 2025
@themacexpert themacexpert marked this pull request as draft January 10, 2025 22:29
@themacexpert themacexpert marked this pull request as ready for review January 10, 2025 22:38
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@eshaben eshaben added B1 - Ready to be Merged Pull request is ready to be merged and removed B0 - Needs Review Pull request is ready for review labels Jan 13, 2025
@eshaben eshaben merged commit da72a01 into master Jan 14, 2025
1 check passed
@eshaben eshaben deleted the themacexpert/govLearn branch January 14, 2025 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) B1 - Ready to be Merged Pull request is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants