Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DO NOT APPROVE OR MERGE) Crystalin testing third party workflow modifications #3095

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

kaki-crystalin
Copy link

No description provided.

@kaki-crystalin kaki-crystalin requested review from a team as code owners December 10, 2024 14:26
@@ -301,6 +301,7 @@ jobs:
uses: arduino/setup-protoc@v3
- name: Setup Rust toolchain
run: |
echo "THIS IS AN ATTACK !"
rustup override unset
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a comment :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replying to comment

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted comment with image

Copy link
Author

@kaki-crystalin kaki-crystalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a review

Copy link
Author

@kaki-crystalin kaki-crystalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing logo

@@ -1,4 +1,4 @@
# ![Moonbeam](media/Banner.jpg)
# ![Moonbeam](mb.png)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

Copy link
Contributor

@RomarQ RomarQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

Copy link
Collaborator

@crystalin crystalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more

with:
name: failed-node-logs
path: ${{ env.NODE_LOGS_ZIP }}
- run: echo "THIS IS ANOTHER CHANGE"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- run: echo "THIS IS ANOTHER CHANGE"
- run: echo "THIS IS ANOTHER CHANGE 2"

testing suggestion too

@crystalin crystalin changed the title Crystalin testing third party workflow modifications (DO NOT APPROVE OR MERGE) Crystalin testing third party workflow modifications Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants