Do not reward whitelisted validators for candidate inclusion

moondance-labs · Jan 3, 2025 · e4091eb · e4091eb
1 parent f522ceb
commit e4091eb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/solo-chains/runtime/dancelight/src/lib.rs b/solo-chains/runtime/dancelight/src/lib.rs
@@ -523,7 +523,12 @@ pub struct RewardPoints;
 
 impl pallet_authorship::EventHandler<AccountId, BlockNumberFor<Runtime>> for RewardPoints {
     fn note_author(author: AccountId) {
-        ExternalValidatorsRewards::reward_by_ids(vec![(author, 20u32)])
+        let whitelisted_validators =
+            pallet_external_validators::WhitelistedValidatorsBackup::<Runtime>::get();
+        // Do not reward whitelisted validators
+        if !whitelisted_validators.contains(&author) {
+            ExternalValidatorsRewards::reward_by_ids(vec![(author, 20u32)])
+        }
     }
 }
 

diff --git a/test/suites/dev-tanssi-relay/external-validators-rewards/test_external_validator_rewards.ts b/test/suites/dev-tanssi-relay/external-validators-rewards/test_external_validator_rewards.ts
@@ -30,7 +30,6 @@ describeSuite({
                     .query.externalValidatorsRewards.rewardPointsForEra(0);
                 const totalRewards = validatorRewards.total.toBigInt();
 
-                // TODO: this test should fail because alice will not be rewarded, why doesn't it fail
                 const blockNumber = (await polkadotJs.rpc.chain.getHeader()).number.toBigInt();
 
                 // 20 points per block