Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy sudo validator, session-key management, and staking #794

Merged
merged 7 commits into from
Jan 3, 2025

Conversation

girazoki
Copy link
Collaborator

@girazoki girazoki commented Jan 2, 2025

Adds the following proxies:

  • sudoValidatorManagement: to be able to handle through sudo externalValidators and slashes
  • SessionKeyManagement: to be able to handle session-keys through a proxy
  • Staking: to be able to handle staking operations through session-keys

@girazoki girazoki added a0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Jan 2, 2025
Copy link
Contributor

github-actions bot commented Jan 2, 2025

WASM runtime size check:

Compared to target branch

dancebox runtime: 1416 KB (no changes) ✅

flashbox runtime: 824 KB (no changes) ✅

dancelight runtime: 2152 KB (+2152 KB) ⚠️

container chain template simple runtime: 1124 KB (-4296 KB) ✅

container chain template frontier runtime: 1400 KB (-5152 KB) ✅

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Coverage Report

(master)

@@                       Coverage Diff                        @@
##           master   girazoki-proxy-sudoValidator      +/-   ##
================================================================
- Coverage   65.25%                         65.24%   -0.01%     
  Files         329                            329              
+ Lines       57691                          57701      +10     
================================================================
  Hits        37646                          37646              
+ Misses      20045                          20055      +10     
Files Changed Coverage
/solo-chains/runtime/dancelight/src/lib.rs 67.60% (-0.39%)

Coverage generated Fri Jan 3 11:57:49 UTC 2025

@girazoki girazoki merged commit 051fb19 into master Jan 3, 2025
42 checks passed
@girazoki girazoki deleted the girazoki-proxy-sudoValidator branch January 3, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants