Do not reward whitelisted validators #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WASM runtime size check:Compared to target branchdancebox runtime: 1420 KB (no changes) ✅ flashbox runtime: 824 KB (no changes) ✅ dancelight runtime: 2160 KB (no changes) ✅ container chain template simple runtime: 1124 KB (no changes) ✅ container chain template frontier runtime: 1400 KB (no changes) ✅ |
Coverage Report@@ Coverage Diff @@
## master tomasz-whitelisted-not-rewarded +/- ##
==================================================================
Coverage 65.59% 65.59% 0.00%
Files 331 331
+ Lines 57998 58048 +50
==================================================================
+ Hits 38041 38071 +30
+ Misses 19957 19977 +20
|
tmpolaczyk
added
B7-runtimenoteworthy
tmpolaczyk
commented
Jan 8, 2025
girazoki
reviewed
Jan 14, 2025
girazoki
reviewed
Jan 14, 2025
girazoki
reviewed
Jan 14, 2025
girazoki
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
looks good @tmpolaczyk , a few nitpicks on naming &/ a bit more unitest, but other than that looks good
Agusrodri
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whitelisted validators are set by root and they do not exist in the ethereum world. Dancelight rewards are minted in ethereum. Therefore, it does not make sense to reward whitelisted validators, as they won't be able to claim that reward.