Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify slashes queue processing #800

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

nanocryk
Copy link
Contributor

@nanocryk nanocryk commented Jan 8, 2025

Simplified how slashes queue is constructed and processed, and trigger "page" processing once every block.

Copy link
Contributor

github-actions bot commented Jan 8, 2025

WASM runtime size check:

Compared to target branch

dancebox runtime: 1416 KB (no changes) ✅

flashbox runtime: 824 KB (no changes) ✅

dancelight runtime: 2156 KB (no changes) ✅

container chain template simple runtime: 1124 KB (no changes) ✅

container chain template frontier runtime: 1400 KB (no changes) ✅

@nanocryk nanocryk merged commit e647800 into agustin-map-slashes Jan 8, 2025
34 of 42 checks passed
@nanocryk nanocryk deleted the jeremy_slashes_on_initialize branch January 8, 2025 15:17
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Coverage Report

(master)

@@                              Coverage Diff                              @@
##           agustin-map-slashes   jeremy_slashes_on_initialize      +/-   ##
=============================================================================
+ Coverage                65.24%                         65.28%   +0.04%     
  Files                      329                            329              
- Lines                    57701                          57694       -7     
=============================================================================
+ Hits                     37646                          37664      +18     
- Misses                   20055                          20030      -25     
Files Changed Coverage
/pallets/external-validator-slashes/src/lib.rs 78.10% (+3.39%)
/pallets/external-validators-rewards/src/lib.rs 89.58% (+1.39%)
/primitives/bridge/src/lib.rs 54.89% (-2.91%)
/primitives/bridge/src/symbiotic_message_processor.rs 90.00% (-2.00%)

Coverage generated Wed Jan 8 16:01:50 UTC 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants