Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notify: create telemetry spans when sending emails, pd, slack #212

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

adamdecaf
Copy link
Member

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (6dbedc8) 48.91% compared to head (b93349e) 48.97%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
+ Coverage   48.91%   48.97%   +0.06%     
==========================================
  Files          87       87              
  Lines        4042     4059      +17     
==========================================
+ Hits         1977     1988      +11     
- Misses       1744     1750       +6     
  Partials      321      321              
Files Coverage Δ
internal/incoming/stream/publisher.go 66.66% <100.00%> (+2.38%) ⬆️
internal/notify/mock_sender.go 57.14% <100.00%> (ø)
internal/notify/multi.go 53.24% <100.00%> (+0.68%) ⬆️
internal/notify/slack.go 80.39% <100.00%> (+1.66%) ⬆️
internal/notify/email.go 59.57% <60.00%> (+2.27%) ⬆️
internal/notify/kafka.go 0.00% <0.00%> (ø)
internal/pipeline/aggregate.go 49.16% <0.00%> (-0.84%) ⬇️
internal/notify/pagerduty.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamdecaf adamdecaf merged commit 7ea6a6f into master Nov 9, 2023
7 checks passed
@adamdecaf adamdecaf deleted the notify-telemetry branch November 9, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants